]> git.karo-electronics.de Git - linux-beck.git/commit
rtc: ep93xx: Fix 'rtc' may be used uninitialized warning
authorAxel Lin <axel.lin@gmail.com>
Wed, 10 Aug 2011 13:11:26 +0000 (21:11 +0800)
committerJohn Stultz <john.stultz@linaro.org>
Wed, 10 Aug 2011 22:54:24 +0000 (15:54 -0700)
commitbf6ed027bcc93f8d54d321fe87f0434b25699eb1
treed4a4a0d65edd98eb64d7b4cde72098fdbb21c295
parent322a8b034003c0d46d39af85bf24fee27b902f48
rtc: ep93xx: Fix 'rtc' may be used uninitialized warning

commit 92d921c5d "rtc: ep93xx: Initialize drvdata before registering device"
ensures the drvdata is initialized prior to registering the rtc device.
But it set the drvdata to an uninitialized pointer.
Thus calling platform_get_drvdata in ep93xx_rtc_remove does not get correct address.

This patch fixes below warning by adding struct rtc_device *rtc to struct ep93xx_rtc.
Then set platform drvdata to ep93xx_rtc instead of rtc.

  CC      drivers/rtc/rtc-ep93xx.o
drivers/rtc/rtc-ep93xx.c: In function 'ep93xx_rtc_probe':
drivers/rtc/rtc-ep93xx.c:154: warning: 'rtc' may be used uninitialized in this function

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-ep93xx.c