]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cdrom: use copy_to_user() without the underscores
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 6 Feb 2012 09:20:45 +0000 (10:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Mar 2012 00:31:24 +0000 (16:31 -0800)
commitc1dd346c39c2a7d3ca7b9670e9504ae19d4e927a
treee6b13900e4112af42a0498e624d641c08ed0cee9
parent203aa5260edca2ab1872ad8b08386d874f7132f3
cdrom: use copy_to_user() without the underscores

commit 822bfa51ce44f2c63c300fdb76dc99c4d5a5ca9f upstream.

"nframes" comes from the user and "nframes * CD_FRAMESIZE_RAW" can wrap
on 32 bit systems.  That would have been ok if we used the same wrapped
value for the copy, but we use a shifted value.  We should just use the
checked version of copy_to_user() because it's not going to make a
difference to the speed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cdrom/cdrom.c