]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[PATCH] i2c-viapro: Code cleanups
authorJean Delvare <khali@linux-fr.org>
Thu, 22 Sep 2005 20:01:07 +0000 (22:01 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 28 Oct 2005 21:02:08 +0000 (14:02 -0700)
commitc2f559d5df5751780c0bd3ea0bd0aa17d47c0b39
tree96af915d018b5145b6e57bf450f5cd29cebeca79
parentf118301416953d677de738100c33eb8cfb7adecb
[PATCH] i2c-viapro: Code cleanups

Cleanups to the i2c-viapro driver:
* Kill unused defines.
* Kill interrupt-related code, as the driver doesn't use interrupts.
* Fix broken comments (some copied from i2c-piix4.)
* Centralize the unsupported command error case in vt596_access.
  That way we'll catch all unsupported commands, not only
  I2C_SMBUS_PROC_CALL.
* Refactor some code.
* Convert some dev_dbg into dev_err. Errors better be reported even in
  non-debug mode.
* Do not verify that the final reset succeeded. It'll be checked at
  the beginning of the next transaction anyway.
* Use the driver name to reserve the I/O region.
* Do not print the contents of the SMBREV register, it reads 0 on all
  chips I've seen so far.
* Some other minor fixes all over the place.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
 drivers/i2c/busses/i2c-viapro.c |  122 +++++++++++++---------------------------
 1 file changed, 41 insertions(+), 81 deletions(-)
drivers/i2c/busses/i2c-viapro.c