]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xfrm_user: fix info leak in copy_to_user_tmpl()
authorMathias Krause <minipli@googlemail.com>
Wed, 19 Sep 2012 11:33:41 +0000 (11:33 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Oct 2012 20:28:05 +0000 (05:28 +0900)
commitc33fcb85ee97f354c5fbdb841b0be01a9c90f9b5
tree538206d7fa421cbefb581a222befefcbb982e8f2
parenta601da719c73cedba80c788719594990e30a972f
xfrm_user: fix info leak in copy_to_user_tmpl()

[ Upstream commit 1f86840f897717f86d523a13e99a447e6a5d2fa5 ]

The memory used for the template copy is a local stack variable. As
struct xfrm_user_tmpl contains multiple holes added by the compiler for
alignment, not initializing the memory will lead to leaking stack bytes
to userland. Add an explicit memset(0) to avoid the info leak.

Initial version of the patch by Brad Spengler.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Brad Spengler <spender@grsecurity.net>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/xfrm/xfrm_user.c