]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 3 Aug 2011 00:52:43 +0000 (10:52 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 5 Aug 2011 02:52:18 +0000 (12:52 +1000)
commitc40b08103ac7d7cb561a29c6b87dbe33945ffa3d
tree7f63cbb87ca36f0ef70417399586a42045d60ef0
parent37e7db37f56381f781203f69cb4a83ede8f6d31d
ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
ext4.  Only two ext4_{set,clear}_bit() calls check the return value.  The
rest of calls ignore the return value and they can be replaced with
__{set,clear}_bit_le().

This changes ext4_{set,clear}_bit() from __test_and_{set,clear}_bit_le()
to __{set,clear}_bit_le() and introduces ext4_test_and_{set,clear}_bit()
for the two places where old bit needs to be returned.

This ext4_{set,clear}_bit() change is considered safe, because if someone
uses these macros without noticing the change, new ext4_{set,clear}_bit
don't have return value and causes compiler errors where the return value
is used.

This also removes unused ext4_find_first_zero_bit().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ext4/ext4.h
fs/ext4/ialloc.c