]> git.karo-electronics.de Git - linux-beck.git/commit
ceph: add cpu_to_le32() calls when encoding a reconnect capability
authorJim Schutt <jaschut@sandia.gov>
Wed, 15 May 2013 18:03:35 +0000 (13:03 -0500)
committerAlex Elder <elder@inktank.com>
Fri, 17 May 2013 17:45:43 +0000 (12:45 -0500)
commitc420276a532a10ef59849adc2681f45306166b89
tree2930964454c9e6e83709d5f96407a4b53a7e6f65
parent14d2f38df67fadee34625fcbd282ee22514c4846
ceph: add cpu_to_le32() calls when encoding a reconnect capability

In his review, Alex Elder mentioned that he hadn't checked that
num_fcntl_locks and num_flock_locks were properly decoded on the
server side, from a le32 over-the-wire type to a cpu type.
I checked, and AFAICS it is done; those interested can consult
    Locker::_do_cap_update()
in src/mds/Locker.cc and src/include/encoding.h in the Ceph server
code (git://github.com/ceph/ceph).

I also checked the server side for flock_len decoding, and I believe
that also happens correctly, by virtue of having been declared
__le32 in struct ceph_mds_cap_reconnect, in src/include/ceph_fs.h.

Cc: stable@vger.kernel.org # 3.4+
Signed-off-by: Jim Schutt <jaschut@sandia.gov>
Reviewed-by: Alex Elder <elder@inktank.com>
fs/ceph/locks.c
fs/ceph/mds_client.c