]> git.karo-electronics.de Git - karo-tx-linux.git/commit
MIPS: KVM: Fix memory leak on VCPU
authorDeng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Tue, 24 Jun 2014 17:31:08 +0000 (10:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Jul 2014 01:57:29 +0000 (18:57 -0700)
commitc42ce86f16548e6bcfa14cfb519c60eb2cd7d4d4
tree42f89607c0fd7a2bd827114b65ab56b1a8140113
parent206b7b9aba46768ef946e50d0e297a4a21b44e88
MIPS: KVM: Fix memory leak on VCPU

commit 8c9eb041cf76038eb3b62ee259607eec9b89f48d upstream.

kvm_arch_vcpu_free() is called in 2 code paths:

1) kvm_vm_ioctl()
       kvm_vm_ioctl_create_vcpu()
           kvm_arch_vcpu_destroy()
               kvm_arch_vcpu_free()
2) kvm_put_kvm()
       kvm_destroy_vm()
           kvm_arch_destroy_vm()
               kvm_mips_free_vcpus()
                   kvm_arch_vcpu_free()

Neither of the paths handles VCPU free. We need to do it in
kvm_arch_vcpu_free() corresponding to the memory allocation in
kvm_arch_vcpu_create().

Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/kvm/kvm_mips.c