]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hwmon: (lm73} Detect and report i2c bus errors
authorChris Verges <kg4ysn@gmail.com>
Fri, 21 Dec 2012 09:58:34 +0000 (01:58 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 16 Jan 2013 01:13:12 +0000 (01:13 +0000)
commitc53ed31e4e663833a8e7ccb06ab0358ff1507a87
tree5c2cf8c5bb3f7b0bc47f34276ee53d9e83e73333
parent7a55283222cdd70c1cd7a33df0db1e0c96462ac9
hwmon: (lm73} Detect and report i2c bus errors

commit 0602934f302e016e2ea5dc6951681bfac77455ef upstream.

If an LM73 device does not exist on an I2C bus, attempts to communicate
with the device result in an error code returned from the i2c read/write
functions.  The current lm73 driver casts that return value from a s32
type to a s16 type, then converts it to a temperature in celsius.
Because negative temperatures are valid, it is difficult to distinguish
between an error code printed to the response buffer and a negative
temperature recorded by the sensor.

The solution is to evaluate the return value from the i2c functions
before performing any temperature calculations.  If the i2c function did
not succeed, the error code should be passed back through the virtual
file system layer instead of being printed into the response buffer.

Before:

   $ cat /sys/class/hwmon/hwmon0/device/temp1_input
   -46

After:

   $ cat /sys/class/hwmon/hwmon0/device/temp1_input
   cat: read error: No such device or address

Signed-off-by: Chris Verges <kg4ysn@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hwmon/lm73.c