]> git.karo-electronics.de Git - karo-tx-linux.git/commit
usermodehelper: kill the sub_info->path[0] check
authorOleg Nesterov <oleg@redhat.com>
Wed, 19 Jun 2013 00:08:17 +0000 (10:08 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 19 Jun 2013 07:27:39 +0000 (17:27 +1000)
commitc63d61182a4d2653de3ac2c7233527dde7cf4453
treef2e3456806969f494266486c016e1ea41a782d13
parente438d66aec2ce76da6ffdc8115f75e530c5480e6
usermodehelper: kill the sub_info->path[0] check

call_usermodehelper_exec() does nothing but returns success if path[0] ==
0.  The only user which needs this strange feature is request_module(), it
can check modprobe_path[0] itself like other users do if they want to
detect the "disabled by admin" case.

Kill it.  Not only it looks strange, it can confuse other callers.  And
this allows us to revert 264b83c0 ("usermodehelper: check
subprocess_info->path != NULL"), do_execve(NULL) is safe.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/kmod.c