]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dma: pl330: rip out broken, redundant ID probing
authorWill Deacon <will.deacon@arm.com>
Mon, 10 Jun 2013 18:34:37 +0000 (19:34 +0100)
committerVinod Koul <vinod.koul@intel.com>
Wed, 12 Jun 2013 05:31:02 +0000 (11:01 +0530)
commitc64c69d612a9fd3960e799041822c51a3fbbaa97
tree7ef8cb4b07ac56f28fa6269c1a8291bded9720e1
parent615cc96ddb61b32a6b091116050fdb506c742332
dma: pl330: rip out broken, redundant ID probing

The PL330 driver probes the peripheral and primecell IDs of the device to
make sure that it is indeed an AMBA PL330. However, it does this by
making byte accesses to a device mapping of the word-aligned ID
registers, which is either UNPREDICTABLE or generates an alignment fault
(depending on the presence of the virtualisation extensions).

Rather than fix this code, we can actually rip most of it out and let
the AMBA bus driver correctly do the probing for us.

Cc: Jassi Brar <jaswinder.singh@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Acked-by: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/pl330.c