]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net/core: neighbour update Oops
authorDoug Kehn <rdkehn@yahoo.com>
Thu, 15 Jul 2010 01:02:16 +0000 (18:02 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:29:28 +0000 (10:29 -0700)
commitc80123ba3fbb7b40566354f54eba4c01f544b1b4
tree491f580c992855346a8f3a9cd7bb472e7b76ee64
parent49dcc8eb452542c4ba40d8caa6a2a544c44ede7a
net/core: neighbour update Oops

commit 91a72a70594e5212c97705ca6a694bd307f7a26b upstream.

When configuring DMVPN (GRE + openNHRP) and a GRE remote
address is configured a kernel Oops is observed.  The
obserseved Oops is caused by a NULL header_ops pointer
(neigh->dev->header_ops) in neigh_update_hhs() when

void (*update)(struct hh_cache*, const struct net_device*, const unsigned char *)
= neigh->dev->header_ops->cache_update;

is executed.  The dev associated with the NULL header_ops is
the GRE interface.  This patch guards against the
possibility that header_ops is NULL.

This Oops was first observed in kernel version 2.6.26.8.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/neighbour.c