]> git.karo-electronics.de Git - linux-beck.git/commit
remoteproc: fix vdev reference management
authorLoic Pallardy <loic.pallardy@st.com>
Wed, 14 Dec 2016 15:11:00 +0000 (16:11 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Fri, 30 Dec 2016 11:15:42 +0000 (03:15 -0800)
commitc81c0e0710f031cb09eb7cbf0e75e6754d1d8346
treee517c5a8f9c4c359908d192eb64c69acb237938a
parent7ce7d89f48834cefece7804d38fc5d85382edf77
remoteproc: fix vdev reference management

Commit 2b45cef5868a ("remoteproc: Further extend the vdev life cycle")
extends kref support for vdev management.
It introduces a regression when following sequence is executed:
rproc_boot --> rproc_shutdown --> rproc_boot
Second rproc_boot call crashes on register_virtio_device as device
is already existing.
Issue is previous vdev is never released when rproc is stop because
associated refcount is too high.

kref_get introduces is not needed as kref_init already initializes
krefcount to 1 because it considers associated variable as used.
This introduces a misalignment between kref_get and kref_put calls.

Fixes: 2b45cef5868a ("remoteproc: Further extend the vdev life cycle")
Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/remoteproc_core.c