]> git.karo-electronics.de Git - karo-tx-linux.git/commit
can: c_can_pci: fix null-pointer-deref in c_can_start() - set device pointer
authorEinar Jón <tolvupostur@gmail.com>
Fri, 12 Aug 2016 11:50:41 +0000 (13:50 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 18 Jan 2017 11:58:26 +0000 (12:58 +0100)
commitc97c52be78b8463ac5407f1cf1f22f8f6cf93a37
treebc1c38d0284615cba4e6d34781acbf320fe006a8
parent93b43fd137cd8865adf9978ab9870a344365d3af
can: c_can_pci: fix null-pointer-deref in c_can_start() - set device pointer

The priv->device pointer for c_can_pci is never set, but it is used
without a NULL check in c_can_start(). Setting it in c_can_pci_probe()
like c_can_plat_probe() prevents c_can_pci.ko from crashing, with and
without CONFIG_PM.

This might also cause the pm_runtime_*() functions in c_can.c to
actually be executed for c_can_pci devices - they are the only other
place where priv->device is used, but they all contain a null check.

Signed-off-by: Einar Jón <tolvupostur@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/c_can/c_can_pci.c