]> git.karo-electronics.de Git - karo-tx-linux.git/commit
IB/cm: Bump reference count on cm_id before invoking callback
authorSean Hefty <sean.hefty@intel.com>
Wed, 23 Feb 2011 16:17:40 +0000 (08:17 -0800)
committerAK <andi@firstfloor.org>
Thu, 31 Mar 2011 18:58:38 +0000 (11:58 -0700)
commitca78068b35522c820207b36191cba1385163f198
tree5c263f66c9eff5db1006785f3cda3ea1900b01fb
parentaf8c55e566b98985bde53ce09e72afcc6db04d4f
IB/cm: Bump reference count on cm_id before invoking callback

commit 29963437a48475036353b95ab142bf199adb909e upstream.

When processing a SIDR REQ, the ib_cm allocates a new cm_id.  The
refcount of the cm_id is initialized to 1.  However, cm_process_work
will decrement the refcount after invoking all callbacks.  The result
is that the cm_id will end up with refcount set to 0 by the end of the
sidr req handler.

If a user tries to destroy the cm_id, the destruction will proceed,
under the incorrect assumption that no other threads are referencing
the cm_id.  This can lead to a crash when the cm callback thread tries
to access the cm_id.

This problem was noticed as part of a larger investigation with kernel
crashes in the rdma_cm when running on a real time OS.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Acked-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/infiniband/core/cm.c