]> git.karo-electronics.de Git - linux-beck.git/commit
x86/ptrace: Down with test_thread_flag(TIF_IA32)
authorDmitry Safonov <dsafonov@virtuozzo.com>
Mon, 5 Sep 2016 13:33:07 +0000 (16:33 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 14 Sep 2016 19:28:11 +0000 (21:28 +0200)
commitcc87324b3dbb9bdf6916c7f479230db24c4aa309
tree1d99aad39474748db8396e889ff394db5ae50934
parent90954e7b940778478754452f1ec8b23ea9a9ad42
x86/ptrace: Down with test_thread_flag(TIF_IA32)

As the task isn't executing at the moment of {GET,SET}REGS,
return regset that corresponds to code selector, rather than
value of TIF_IA32 flag.
I.e. if we ptrace i386 elf binary that has just changed it's
code selector to __USER_CS, than GET_REGS will return
full x86_64 register set.

Note, that this will work only if application has changed it's CS.
If the application does 32-bit syscall with __USER_CS, ptrace
will still return 64-bit register set. Which might be still confusing
for tools that expect TS_COMPACT to be exposed [1, 2].

So this this change should make PTRACE_GETREGSET more reliable and
this will be another step to drop TIF_{IA32,X32} flags.

[1]: https://sourceforge.net/p/strace/mailman/message/30471411/
[2]: https://lkml.org/lkml/2012/1/18/320

Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: 0x7f454c46@gmail.com
Cc: oleg@redhat.com
Cc: linux-mm@kvack.org
Cc: luto@kernel.org
Cc: Pedro Alves <palves@redhat.com>
Cc: gorcunov@openvz.org
Cc: xemul@virtuozzo.com
Link: http://lkml.kernel.org/r/20160905133308.28234-6-dsafonov@virtuozzo.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/ptrace.c