]> git.karo-electronics.de Git - linux-beck.git/commit
f2fs: fix writing incorrect orphan blocks
authorJaegeuk Kim <jaegeuk.kim@samsung.com>
Tue, 8 Oct 2013 01:19:28 +0000 (10:19 +0900)
committerJaegeuk Kim <jaegeuk.kim@samsung.com>
Tue, 8 Oct 2013 01:19:28 +0000 (10:19 +0900)
commitccaaca25919a2cdeccd8fdce5f546e3ed7f6a9e9
tree225d4bc2a01b6e6331081754af1beb9875ea34be
parent5887d291d792773368f6eaf1759aad109bcd78eb
f2fs: fix writing incorrect orphan blocks

Previously, there was a erroneous scenario like below.
thread 1:                       thread 2:
 f2fs_unlink
  - acquire_orphan_inode
    : sbi->n_orphans++           write_checkpoint
                                 - block_operations
                                  : f2fs_lock_all
                                 - do_checkpoint
                                  : write orphan blocks with sbi->n_orphans
                                 - unblock_operations
  - f2fs_lock_op
  - release_orphan_inode
  - f2fs_unlock_op

During the checkpoint by thread 2, f2fs stores a wrong orphan block according
to the wrong sbi->n_orphans.
To avoid this, simply we should make cover acquire_orphan_inode too with
f2fs_lock_op.

Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
fs/f2fs/namei.c