]> git.karo-electronics.de Git - linux-beck.git/commit
dmaengine: at_hdmac: use tasklet_kill in teardown
authorVinod Koul <vinod.koul@intel.com>
Thu, 6 Mar 2014 06:54:08 +0000 (12:24 +0530)
committerVinod Koul <vinod.koul@intel.com>
Mon, 17 Mar 2014 13:03:43 +0000 (18:33 +0530)
commitccc7aad04c95c33407444b1387e42162925e5216
treebf6beb993329e1a76e6037fe8933455e0a9292b8
parentb28a960c42fcd9cfc987441fa6d1c1a471f0f9ed
dmaengine: at_hdmac: use tasklet_kill in teardown

As discussed in [1] the tasklet_disable is not a proper function for teardown.
We need to ensure irq is disabled, followed by ensuring that don't schedule any
more tasklets and then its safe to use tasklet_kill().

Here in at_hdmac driver we use free_irq() before tasklet_kill(). The free_irq()
will ensure that the irq is disabled and also wait till all scheduled interrupts
are executed by invoking synchronize_irq(). So we need to only do tasklet_kill()
after invoking free_irq()

[1]: http://lwn.net/Articles/588457/

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/at_hdmac.c