]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] pxa_camera: Fix a call with an uninitialized device pointer
authorPetr Cvek <petr.cvek@tul.cz>
Mon, 1 May 2017 04:21:57 +0000 (01:21 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 10:41:10 +0000 (07:41 -0300)
commitce550362c5cf1e50f8116ba00f2e5bdb3ed151dd
treea681bf8c351166e3c629c4375c1c56773bd1985f
parenta065c2e52744b302d408436fbc1f153696ae0bd0
[media] pxa_camera: Fix a call with an uninitialized device pointer

In 'commit 295ab497d6357 ("[media] media: platform: pxa_camera: make
printk consistent")' a pointer to the device structure in
mclk_get_divisor() was changed to pcdev_to_dev(pcdev). The pointer used
by pcdev_to_dev() is still uninitialized during the call to
mclk_get_divisor() as it happens in v4l2_device_register() at the end
of the probe. The dev_warn and dev_dbg caused a line in the log:

(NULL device *): Limiting master clock to 26000000

Fix this by using an initialized pointer from the platform_device
(as before the old patch).

Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/pxa_camera.c