]> git.karo-electronics.de Git - linux-beck.git/commit
iser-target: Fix REJECT CM event use-after-free OOPs
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 24 Jul 2015 02:29:55 +0000 (02:29 +0000)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 24 Jul 2015 21:19:45 +0000 (14:19 -0700)
commitce9a9fc20a78ad1e5222fae3a83d105f2d2fb9b9
tree50f1c9958f6dedce7e267eec61769744f797b949
parent007d038bdf95ccfe2491d0078be54040d110fd06
iser-target: Fix REJECT CM event use-after-free OOPs

This patch fixes a bug in iser-target code where the REJECT CM event
handler code currently performs a isert_put_conn() for the final
isert_conn->kref put, while iscsi_np process context is still blocked
in isert_get_login_rx().

Once isert_get_login_rx() is awoking due to login timeout, iscsi_np
process context will attempt to invoke iscsi_target_login_sess_out()
to cleanup iscsi_conn as expected, and calls isert_wait_conn() +
isert_free_conn() which triggers the use-after-free OOPs.

To address this bug, move the kref_get_unless_zero() call from
isert_connected_handler() into isert_connect_request() immediately
preceeding isert_rdma_accept() to ensure the CM handler cleanup
paths and isert_free_conn() are always operating with two refs.

Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c