]> git.karo-electronics.de Git - karo-tx-linux.git/commit
checkpatch: improve tests for fixes:, long lines and stack dumps in commit log
authorJoe Perches <joe@perches.com>
Wed, 21 Oct 2015 22:03:54 +0000 (09:03 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 21 Oct 2015 22:03:54 +0000 (09:03 +1100)
commitcebb768c984778e700e974a946eadb31daa21f77
tree38be8552ad6c781b1cfb5860d5d82d9f646a2293
parent1d7d35a37770eef71b4e3a6756158fd9791d297c
checkpatch: improve tests for fixes:, long lines and stack dumps in commit log

Including BUG and stack dumps in commit logs makes checkpatch produce some
false positive warning messages.

checkpatch has multiple types of false positives:

o Commit message lines > 75 chars
o Stack dump address are mistaken for git commit IDs
o Link: and Fixes: lines are allowed to be > 75 chars.
o Fixes: style doesn't require ("<commit_description>")
  parentheses and double quotes like other uses of
  git commit ID and description.

Fix these.

Miscellanea:

o Move the test for checking $commit_log_possible_stack_dump
  above the test for a long line commit message
o Add test for hex address surrounded by square or angle brackets

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/checkpatch.pl