]> git.karo-electronics.de Git - linux-beck.git/commit
firmware: dmi-sysfs: Remove "dmi" directory on module exit
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 5 Dec 2013 23:46:35 +0000 (16:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2013 02:23:42 +0000 (18:23 -0800)
commitd0f80f9aadf60adc4caafed0d2b01e79a315ff80
treeae7e21c5105ca8f4454055400aa68ae9678d8029
parenta61aca2854eaecf2d1bffbaf1fc368fb1a20c850
firmware: dmi-sysfs: Remove "dmi" directory on module exit

With CONFIG_DEBUG_KOBJECT_RELEASE=y, removing and immediately reloading the
dmi-sysfs module causes the following warning:

  sysfs: cannot create duplicate filename '/firmware/dmi'
  kobject_add_internal failed for dmi with -EEXIST, don't try to register things with the same name in the same directory.

The "dmi" directory stays in sysfs until the dmi_kobj is released, and
DEBUG_KOBJECT_RELEASE delays that.

I don't think we can hit this problem in normal usage because dmi_kobj is
static and nothing outside dmi-sysfs can get a reference to it, so the
only way to delay the "dmi" release is with DEBUG_KOBJECT_RELEASE.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/dmi-sysfs.c