]> git.karo-electronics.de Git - linux-beck.git/commit
memory: tegra: Delete unneeded of_node_put()
authorJulia Lawall <julia.lawall@lip6.fr>
Fri, 9 Oct 2015 17:47:40 +0000 (19:47 +0200)
committerThierry Reding <treding@nvidia.com>
Tue, 14 Jun 2016 09:39:39 +0000 (11:39 +0200)
commitd1122e4b7639941305166628613a42fdf6e16296
tree6eb7e1446979d44820e5725ffe4989ee42a912ec
parentaafb197f75cec20331c84ade2da9bc94ae0b9aff
memory: tegra: Delete unneeded of_node_put()

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/memory/tegra/mc.c
drivers/memory/tegra/tegra124-emc.c