]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode
authorChristian Borntraeger <borntraeger@de.ibm.com>
Sat, 15 May 2010 04:00:00 +0000 (00:00 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 6 Jan 2011 23:07:34 +0000 (18:07 -0500)
commitd14f90a2e15b6312b5c25ec445edecbb77b3cd1c
treea387ab9fc08822f7b0fa4ad8e58898f0fdf3559a
parentc486048538a69b481800ce677db2b714625fbfdc
ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode

commit b684b2ee9409f2890a8b3aea98525bbe5f84e276 upstream.

I have an x86_64 kernel with i386 userspace. e4defrag fails on the
EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat
case. It seems that struct move_extent is compat save, only types
with fixed widths are used:
{
        __u32 reserved;         /* should be zero */
        __u32 donor_fd;         /* donor file descriptor */
        __u64 orig_start;       /* logical start offset in block for orig */
        __u64 donor_start;      /* logical start offset in block for donor */
        __u64 len;              /* block length to be moved */
        __u64 moved_len;        /* moved block length */
};

Lets just wire up EXT4_IOC_MOVE_EXT for the compat case.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
CC: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ext4/ioctl.c