]> git.karo-electronics.de Git - linux-beck.git/commit
drivers/staging/iio: call mutex_unlock in error handling code
authorJulia Lawall <julia@diku.dk>
Wed, 4 Aug 2010 19:54:26 +0000 (21:54 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 31 Aug 2010 18:40:35 +0000 (11:40 -0700)
commitd1ae4da731a6e049a675097ebfd9a02b9b50530e
tree63326555cf48a30edf242d40088083ebe4752704
parente3a92cdedf3584e20e13511aab252a82d715f927
drivers/staging/iio: call mutex_unlock in error handling code

Adjust the error handling code so that it benefits from the call to
mutex_unlock at the end of the function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@rcu exists@
position p1;
expression E;
@@

mutex_lock@p1(E);
...
mutex_unlock(E);

@exists@
position rcu.p1;
expression E;
@@

*mutex_lock@p1(E);
... when != mutex_unlock(E);
?*return ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/iio/magnetometer/hmc5843.c