]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drivers/video: Move dereference after NULL test
authorJulia Lawall <julia@diku.dk>
Wed, 16 Dec 2009 00:46:26 +0000 (16:46 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 16 Dec 2009 15:20:01 +0000 (07:20 -0800)
commitd2a34c13e7ccec5d06eafd60e6f80ea531b34668
tree535f0ba7f4b95d53d3d871bc6a49d2fecf22b052
parent2f390380ca69e1617cdddb12d8da94f0a9f4319d
drivers/video: Move dereference after NULL test

If the NULL test on fbi is needed, then the dereference should be after the
NULL test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/pxafb.c