]> git.karo-electronics.de Git - karo-tx-linux.git/commit
spi: loopback-test: fix potential integer overflow on multiple
authorColin Ian King <colin.king@canonical.com>
Mon, 20 Mar 2017 13:58:05 +0000 (13:58 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 20 Mar 2017 16:11:39 +0000 (16:11 +0000)
commitd2c14c64d678713fced6f2261ce7d398b4351de5
treedac36ad6910b92db430c54ed480c0ecf541d3652
parent8687113e1515f4c9104a6eaedc384ec762c6550f
spi: loopback-test: fix potential integer overflow on multiple

A multiplication of 8U * xfer-len with the type of a 32 bit unsigned int
is evaluated using 32 bit arithmetic and then used in a context that
expects an expression of type unsigned long long (64 bits).  Avoid any
potential overflow by casting BITS_PER_BYTE to unsigned long long.

Detected by CoverityScan, CID#1419691 ("Unintentional integer overflow")

Fixes: ea9936f324356 ("spi: loopback-test: add elapsed time check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-loopback-test.c