]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86: Use u32 instead of long to set reset vector back to 0
authorDon Zickus <dzickus@redhat.com>
Tue, 8 Feb 2011 04:25:00 +0000 (23:25 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 26 Jun 2011 16:46:53 +0000 (12:46 -0400)
commitd333643bbe0d7a0634bc988ae379f8fa602df2f7
tree70f2f4487ca5b2f4d42c7abacf2667b057b025be
parent98fc9c1d3390e780292bd877c77ebf31a1a879d7
x86: Use u32 instead of long to set reset vector back to 0

commit 299c56966a72b9109d47c71a6db52097098703dd upstream.

A customer of ours, complained that when setting the reset
vector back to 0, it trashed other data and hung their box.
They noticed when only 4 bytes were set to 0 instead of 8,
everything worked correctly.

Mathew pointed out:

 |
 | We're supposed to be resetting trampoline_phys_low and
 | trampoline_phys_high here, which are two 16-bit values.
 | Writing 64 bits is definitely going to overwrite space
 | that we're not supposed to be touching.
 |

So limit the area modified to u32.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
LKML-Reference: <1297139100-424-1-git-send-email-dzickus@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
arch/x86/include/asm/smpboot_hooks.h