]> git.karo-electronics.de Git - linux-beck.git/commit
staging: comedi: das1800: fix possible NULL dereference
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 8 Apr 2016 17:14:58 +0000 (10:14 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Apr 2016 05:12:06 +0000 (22:12 -0700)
commitd375278d666760e195693b57415ba0a125cadd55
tree0db4405a889fee0d79333a8993e0d75db8d07088
parent3a56d700f60cd3cdc2c1429d107f0818555a5b22
staging: comedi: das1800: fix possible NULL dereference

DMA is optional with this driver. If it was not enabled the devpriv->dma
pointer will be NULL.

Fix the possible NULL pointer dereference when trying to disable the DMA
channels in das1800_ai_cancel() and tidy up the comments to fix the
checkpatch.pl issues:
WARNING: line over 80 characters

It's probably harmless in das1800_ai_setup_dma() because the 'desc' pointer
will not be used if DMA is disabled but fix it there also.

Fixes: 99dfc3357e98 ("staging: comedi: das1800: remove depends on ISA_DMA_API limitation")
Cc: <stable@vger.kernel.org> # 4.0+
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/das1800.c