]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Fix oops caused by queue refcounting failure
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 25 May 2011 20:52:14 +0000 (15:52 -0500)
committerAndi Kleen <ak@linux.intel.com>
Mon, 1 Aug 2011 20:54:54 +0000 (13:54 -0700)
commitd4df7c4751eefc0130f4f8bdf396a4ea16876dd4
tree9d779890fab4456331461b21949d3429e9b313fd
parentf253441b14e828b6cb0c8d030d3985738730e5fd
Fix oops caused by queue refcounting failure

commit e73e079bf128d68284efedeba1fbbc18d78610f9 upstream.

In certain circumstances, we can get an oops from a torn down device.
Most notably this is from CD roms trying to call scsi_ioctl.  The root
cause of the problem is the fact that after scsi_remove_device() has
been called, the queue is fully torn down.  This is actually wrong
since the queue can be used until the sdev release function is called.
Therefore, we add an extra reference to the queue which is released in
sdev->release, so the queue always exists.

Reported-by: Parag Warudkar <parag.lkml@gmail.com>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/scsi/scsi_scan.c
drivers/scsi/scsi_sysfs.c