]> git.karo-electronics.de Git - linux-beck.git/commit
drm/i915: Fix wrong number of HDMI translation entries
authorDamien Lespiau <damien.lespiau@intel.com>
Sat, 9 Aug 2014 15:29:31 +0000 (16:29 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 11 Aug 2014 09:29:29 +0000 (11:29 +0200)
commitd6699dd3a7f696a80a5f8e5bb6ecf6ff6dd7c998
treecc6ff146510f0738b801e8e41e5c59b91fe342ed
parent3bb11b536c1037143765b4efc8056600438df7f6
drm/i915: Fix wrong number of HDMI translation entries

I keep telling myself that those tables aren't great because their size
is the number of dwords we need to program and not the number of entries
(number of dwords = number of entries * 2).

And... I got it wrong when I refactored the code. Fortunately, it was
only wrong when the VBT table (or the code parsing it) is itself
erroneous. Long story short, it shouldn't matter, but still, there's a
potential array overflow and random programming of the DDI translation
tables.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ddi.c