]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net/core: neighbour update Oops
authorDoug Kehn <rdkehn@yahoo.com>
Thu, 15 Jul 2010 01:02:16 +0000 (18:02 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:20:53 +0000 (10:20 -0700)
commitd7091c2bbded22430db06e5172a3b4c3ee7f3cd8
treeaa381d74e0aa40be668e7feba66084e09f1396e0
parentbc823014630b05fb2deb5cf0a15032de63c41d89
net/core: neighbour update Oops

commit 91a72a70594e5212c97705ca6a694bd307f7a26b upstream.

When configuring DMVPN (GRE + openNHRP) and a GRE remote
address is configured a kernel Oops is observed.  The
obserseved Oops is caused by a NULL header_ops pointer
(neigh->dev->header_ops) in neigh_update_hhs() when

void (*update)(struct hh_cache*, const struct net_device*, const unsigned char *)
= neigh->dev->header_ops->cache_update;

is executed.  The dev associated with the NULL header_ops is
the GRE interface.  This patch guards against the
possibility that header_ops is NULL.

This Oops was first observed in kernel version 2.6.26.8.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/neighbour.c