]> git.karo-electronics.de Git - linux-beck.git/commit
MIPS: smp.c: Fix uninitialised temp_foreign_map
authorJames Hogan <james.hogan@imgtec.com>
Fri, 4 Mar 2016 10:10:51 +0000 (10:10 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Sun, 13 Mar 2016 09:59:19 +0000 (10:59 +0100)
commitd825c06bfe8b885b797f917ad47365d0e9c21fbb
treef825c3681af8a7a962b95c23c4904d27ac5df35f
parent7a50e4688dabb8005df39b2b992d76629b8af8aa
MIPS: smp.c: Fix uninitialised temp_foreign_map

When calculate_cpu_foreign_map() recalculates the cpu_foreign_map
cpumask it uses the local variable temp_foreign_map without initialising
it to zero. Since the calculation only ever sets bits in this cpumask
any existing bits at that memory location will remain set and find their
way into cpu_foreign_map too. This could potentially lead to cache
operations suboptimally doing smp calls to multiple VPEs in the same
core, even though the VPEs share primary caches.

Therefore initialise temp_foreign_map using cpumask_clear() before use.

Fixes: cccf34e9411c ("MIPS: c-r4k: Fix cache flushing for MT cores")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/12759/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/kernel/smp.c