]> git.karo-electronics.de Git - karo-tx-linux.git/commit
SCSI: zalon: fix oops on attach failure
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 24 Jun 2009 19:55:22 +0000 (19:55 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 30 Jul 2009 23:05:59 +0000 (16:05 -0700)
commitd9120d6d357e869bd8d064b38ac33a6b48ba36c9
tree3b4d1cc0aed44aaeefed11aef72e098ea2b851a2
parent77a09356416cd30aaef5111c5a20c2167479e635
SCSI: zalon: fix oops on attach failure

commit d3a263a8168f78874254ea9da9595cfb0f3e96d7 upstream.

I recently discovered on my zalon that if the attachment fails because
of a bus misconfiguration (I scrapped my HVD array, so the card is now
unterminated) then the system oopses.  The reason is that if
ncr_attach() returns NULL (signalling failure) that NULL is passed by
the goto failed straight into ncr_detach() which oopses.

The fix is just to return -ENODEV in this case.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/zalon.c