]> git.karo-electronics.de Git - karo-tx-linux.git/commit
futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()
authorDarren Hart <dvhart@linux.intel.com>
Fri, 20 Jul 2012 18:53:31 +0000 (11:53 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Aug 2012 15:23:24 +0000 (08:23 -0700)
commitd96a21b1f4a68be68d2dcf7f02e224b9daee0c2c
treea5cc71b6786d8f27ff53cc71cb5c8dca443677be
parent20b8502553fb79a8ff3afc7562be25d592620430
futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()

commit 6f7b0a2a5c0fb03be7c25bd1745baa50582348ef upstream.

If uaddr == uaddr2, then we have broken the rule of only requeueing
from a non-pi futex to a pi futex with this call. If we attempt this,
as the trinity test suite manages to do, we miss early wakeups as
q.key is equal to key2 (because they are the same uaddr). We will then
attempt to dereference the pi_mutex (which would exist had the futex_q
been properly requeued to a pi futex) and trigger a NULL pointer
dereference.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Dave Jones <davej@redhat.com>
Link: http://lkml.kernel.org/r/ad82bfe7f7d130247fbe2b5b4275654807774227.1342809673.git.dvhart@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/futex.c