]> git.karo-electronics.de Git - karo-tx-linux.git/commit
leds: bcm6328: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 24 Oct 2015 14:42:29 +0000 (16:42 +0200)
committerJacek Anaszewski <j.anaszewski@samsung.com>
Wed, 28 Oct 2015 11:12:29 +0000 (12:12 +0100)
commitda53e3f21738cf0bb0fb110be26f1773d0166f79
tree7a8cb1bfef938de86ebe6c158aeb2b2c0f36d38d
parent6f43c5b3bd0483ae38c6a7ba91a09829642ee752
leds: bcm6328: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
drivers/leds/leds-bcm6328.c