]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: EHCI: unlink unused QHs when the controller is stopped
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 5 Apr 2011 17:36:15 +0000 (13:36 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:16 +0000 (10:57 -0400)
commitdacc6cb05f9fb19b7c5025ec8bd2a02206130894
tree4368275364f8777ec6c7ffa5f03ee43030fbe515
parentebe2355323bb44d7c04bd7660b767440aec02995
USB: EHCI: unlink unused QHs when the controller is stopped

commit 94ae4976e253757e9b03a44d27d41b20f1829d80 upstream.

This patch (as1458) fixes a problem affecting ultra-reliable systems:
When hardware failover of an EHCI controller occurs, the data
structures do not get released correctly.  This is because the routine
responsible for removing unused QHs from the async schedule assumes
the controller is running properly (the frame counter is used in
determining how long the QH has been idle) -- but when a failover
causes the controller to be electronically disconnected from the PCI
bus, obviously it stops running.

The solution is simple: Allow scan_async() to remove a QH from the
async schedule if it has been idle for long enough _or_ if the
controller is stopped.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-Tested-by: Dan Duval <dan.duval@stratus.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/usb/host/ehci-q.c