]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ACPI / PM: Make acpi_pm_device_sleep_state() follow the specification
authorRafael J. Wysocki <rjw@sisk.pl>
Tue, 29 May 2012 19:21:07 +0000 (21:21 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 25 Jul 2012 03:11:45 +0000 (04:11 +0100)
commitdb4fd57ab669f33ca6ef67e9f0c8074906073726
tree061075e203a62d9ca1ebfb6fb0af13dfa6b34ce5
parent03d200117c06fde714344f8f4f0301f609959b53
ACPI / PM: Make acpi_pm_device_sleep_state() follow the specification

commit dbe9a2edd17d843d80faf2b99f20a691c1853418 upstream.

The comparison between the system sleep state being entered
and the lowest system sleep state the given device may wake up
from in acpi_pm_device_sleep_state() is reversed, because the
specification (ACPI 5.0) says that for wakeup to work:

"The sleeping state being entered must be less than or equal to the
 power state declared in element 1 of the _PRW object."

In other words, the state returned by _PRW is the deepest
(lowest-power) system sleep state the device is capable of waking up
the system from.

Moreover, acpi_pm_device_sleep_state() also should check if the
wakeup capability is supported through ACPI, because in principle it
may be done via native PCIe PME, for example, in which case _SxW
should not be evaluated.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/acpi/sleep.c