]> git.karo-electronics.de Git - karo-tx-linux.git/commit
i2c-smbus: Convert kzalloc to devm_kzalloc
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 2 Oct 2012 00:00:56 +0000 (10:00 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 2 Oct 2012 00:00:56 +0000 (10:00 +1000)
commitdbc0dbcf2ae949c62255d6c544e1c1434ec50623
tree71983da108494b362ed766452770137178f94885
parent85e696f5199ed25861721e1ac04390746ef2249a
i2c-smbus: Convert kzalloc to devm_kzalloc

Converting kzalloc to devm_kzalloc simplifies the code and ensures that the
result, alert, is freed after the irq allocated by the subsequent
devm_request_irq.  This in turn ensures that when an interrupt can be
triggered, the alert structure is still available.

The problem of a free after a devm_request_irq was found using the
following semantic match (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2,x,a,b,c,d;
identifier free;
position p1,p2;
@@

  devm_request_irq@p1(e1,e2,...,x)
  ... when any
      when != e2 = a
      when != x = b
  if (...) {
    ... when != e2 = c
        when != x = d
    free@p2(...,x,...);
    ...
    return ...;
  }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/i2c-smbus.c