]> git.karo-electronics.de Git - karo-tx-linux.git/commit
binfmt_elf: Uninitialized variable
authorAlan Cox <alan@linux.intel.com>
Fri, 28 Sep 2012 00:20:30 +0000 (10:20 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 3 Oct 2012 06:50:48 +0000 (16:50 +1000)
commitdcf731a2c6b0d524eeabf76a67fe66734cf948e3
tree902eab5c3836a32eec4ff56e113ecc67624c6de7
parentc0d436545b8eaa71f1631521a662e1cabb7f2101
binfmt_elf: Uninitialized variable

load_elf_interp() has interp_map_addr carefully described as
"uninitialized_var" and marked so as to avoid a warning.  However if you
trace the code it is passed into load_elf_interp and then this value is
checked against NULL.

As this return value isn't used this is actually safe but it freaks
various analysis tools that see un-initialized memory addresses being read
before their value is ever defined.

Set it to NULL as a matter of programming good taste if nothing else

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/binfmt_elf.c