]> git.karo-electronics.de Git - linux-beck.git/commit
IB/ipoib: Avoid multicast join attempts with invalid P_key
authorAlex Estrin <alex.estrin@intel.com>
Wed, 6 Aug 2014 18:40:32 +0000 (14:40 -0400)
committerRoland Dreier <roland@purestorage.com>
Mon, 11 Aug 2014 02:53:56 +0000 (19:53 -0700)
commitdd57c9308afff61e4c157d0a7260695fe2f9a98c
tree3b3660782cced2f44ea7abdd7d1a14044ccf6028
parent4eae374845affc3ebf8ccfc38d554a86adc95003
IB/ipoib: Avoid multicast join attempts with invalid P_key

Currently, the parent interface keeps sending broadcast group join
requests even if p_key index 0 is invalid, which is possible/common in
virtualized environments where a VF has been probed to VM but the
actual P_key configuration has not yet been assigned by the management
software. This creates unnecessary noise on the fabric and in the
kernel logs:

    ib0: multicast join failed for ff12:401b:8000:0000:0000:0000:ffff:ffff, status -22

The original code run the multicast task regardless of the actual
P_key value, which can be avoided. The fix is to re-init resources and
bring interface up only if P_key index 0 is valid either when starting
up or on PKEY_CHANGE event.

Fixes: c290414169 ("IPoIB: Fix pkey change flow for virtualization environments")
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Alex Estrin <alex.estrin@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/ulp/ipoib/ipoib_ib.c
drivers/infiniband/ulp/ipoib/ipoib_main.c