]> git.karo-electronics.de Git - karo-tx-linux.git/commit
gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable
authorKevin Hilman <khilman@ti.com>
Tue, 23 Oct 2012 18:09:31 +0000 (11:09 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 24 Oct 2012 08:16:22 +0000 (10:16 +0200)
commitdd7ebd6de33c544e1a7afe50abf0f90506c8d62d
tree4e9bc2392daac18b44f280b235c9b3916b4e6096
parentc57d75c099e55500b620f50a207e61b9e20ecd29
gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

When debounce clocks are disabled, ensure that the banks
dbck_enable_mask is cleared also.  Otherwise, context restore on
subsequent off-mode transition will restore previous value from the
shadow copies (bank->context.debounce*) leading to mismatch state
between driver state and hardware state.

This was discovered when board code was doing

  gpio_request_one()
  gpio_set_debounce()
  gpio_free()

which was leaving the GPIO debounce settings in a confused state.
Then, enabling off mode causing bogus state to be restored, leaving
GPIO debounce enabled which then prevented the CORE powerdomain from
transitioning.

Cc: stable@kernel.org
Reported-by: Paul Walmsley <paul@pwsan.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-omap.c