]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: move i9xx dpll enabling into crtc enable function
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 16 Jun 2013 19:24:16 +0000 (21:24 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 26 Jun 2013 10:00:37 +0000 (12:00 +0200)
commitdd970008ec5df7a91e56dea2994dbd0984bfae6f
treed672b9e0fc6d96a724c6e7888ddb3a0f3527cf26
parent6728bee3f3980e276b75ea4124bf88267712b514
drm/i915: move i9xx dpll enabling into crtc enable function

Now that we have the proper pipe config to track this, we don't need
to write any registers any more.

Note that for platforms without DPLL_MD (pre-gen4) which store the
pixel mutliplier in the DPLL register I've decided to keep the
seemingly "redundant" write: The comment right below saying "do this
trice for luck" doesn't instill confidence ...

v2: Drop a few now unnecessary local variables and switch the enable
function to take a struct intel_crtc * to simply arguments.

v3: Rebase on top of the newly-colored BUG_ON.

v4: Amend commit message to alliviate Imre's comment about the
redudant DPLL write for the pixel mutliplier.

Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c