]> git.karo-electronics.de Git - linux-beck.git/commit
tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Feb 2016 15:08:59 +0000 (07:08 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Feb 2016 01:39:36 +0000 (17:39 -0800)
commitdd9b55883e291a69a02a070cb27bc0c326c55bed
treea5ab114751d94d4babe555a19b34450c43a7d165
parent8f5405c9f217cb8c148a9f1372256a99623ca034
tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

IS_ERR_VALUE() assumes that its parameter is an unsigned long.
It can not be used to check if an unsigned int reflects an error.
Doing so can result in the following build warning.

drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’:
include/linux/err.h:21:38: warning:
comparison is always false due to limited range of data type
drivers/tty/serial/digicolor-usart.c:485:6: note:
in expansion of macro ‘IS_ERR_VALUE’

If that warning is seen, an error return from platform_get_irq() is missed.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/digicolor-usart.c