]> git.karo-electronics.de Git - linux-beck.git/commit
USB: serial: keyspan_pda: verify endpoints at probe
authorJohan Hovold <johan@kernel.org>
Tue, 3 Jan 2017 15:39:48 +0000 (16:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Jan 2017 10:39:13 +0000 (11:39 +0100)
commitdda7611ec4a5ced89cebb3a9c48afc9c846a1f83
tree18f75e494933b75148b5a8546aa75531834c71c4
parent69c415ed5c98c03e7f12c5e2cd7d7e5f7708e4f4
USB: serial: keyspan_pda: verify endpoints at probe

commit 5d9b0f859babe96175cd33d7162a9463a875ffde upstream.

Check for the expected endpoints in attach() and fail loudly if not
present.

Note that failing to do this appears to be benign since da280e348866
("USB: keyspan_pda: clean up write-urb busy handling") which prevents a
NULL-pointer dereference in write() by never marking a non-existent
write-urb as free.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/keyspan_pda.c