]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: 6205/1: perf: ensure counter delta is treated as unsigned
authorWill Deacon <will.deacon@arm.com>
Fri, 2 Jul 2010 15:41:52 +0000 (16:41 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:29:43 +0000 (10:29 -0700)
commitddf7095df25ba6d2b1dce8513c5cec250653ae05
treeafbdac539613a8fd37ee55086b46a34061a34b20
parent4ff1176f3e305d525e202ae992f3130f0ace287f
ARM: 6205/1: perf: ensure counter delta is treated as unsigned

commit 446a5a8b1eb91a6990e5c8fe29f14e7a95b69132 upstream.

Hardware performance counters on ARM are 32-bits wide but atomic64_t
variables are used to represent counter data in the hw_perf_event structure.

The armpmu_event_update function right-shifts a signed 64-bit delta variable
and adds the result to the event count. This can lead to shifting in sign-bits
if the MSB of the 32-bit counter value is set. This results in perf output
such as:

 Performance counter stats for 'sleep 20':

 18446744073460670464  cycles             <-- 0xFFFFFFFFF12A6000
        7783773  instructions             #      0.000 IPC
            465  context-switches
            161  page-faults
        1172393  branches

   20.154242147  seconds time elapsed

This patch ensures that the delta value is treated as unsigned so that the
right shift sets the upper bits to zero.

Acked-by: Jamie Iles <jamie.iles@picochip.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/arm/kernel/perf_event.c