]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sched/rt: Remove unnecessary condition in push_rt_task()
authorByungchul Park <byungchul.park@lge.com>
Fri, 12 May 2017 01:05:43 +0000 (10:05 +0900)
committerIngo Molnar <mingo@kernel.org>
Tue, 23 May 2017 08:01:33 +0000 (10:01 +0200)
commitde16b91effdbf5aeff8346b99bcd0991a5362db9
treea0a3fefa5625c3d9c0b3354e52d45ca96b761c40
parent73215849dfbf63421c1cafea5a1b6da9bb17831e
sched/rt: Remove unnecessary condition in push_rt_task()

pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
it returns a task other than NULL, which means that task_cpu(task) must
be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
rq->cpu as well. Remove the redundant condition and make the code simpler.

This way one unnecessary branch and two LOAD operations can be avoided.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Juri Lelli <juri.lelli@arm.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: <kernel-team@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1494551143-22219-1-git-send-email-byungchul.park@lge.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/rt.c