]> git.karo-electronics.de Git - karo-tx-linux.git/commit
GFS2: write_end error path fails to unlock transaction lock
authorBob Peterson <rpeterso@redhat.com>
Wed, 16 Mar 2011 20:32:39 +0000 (16:32 -0400)
committerSteven Whitehouse <swhiteho@redhat.com>
Mon, 18 Apr 2011 14:22:35 +0000 (15:22 +0100)
commitdeab72d3797e3d4340c7ddf968234b8c3d01d7a5
treef09c55adcff084fb1c616184169b1bbf55e7f7ac
parenta1b49cb7e2a7961ec3aa8b64860bf480d4ec9077
GFS2: write_end error path fails to unlock transaction lock

I did an audit of gfs2's transaction glock for bugzilla bug
658619 and ran across this:

In function gfs2_write_end, in the unlikely event that
gfs2_meta_inode_buffer returns an error, the code may forget
to unlock the transaction lock because the "failed" label
appears after the call to function gfs2_trans_end.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/aops.c