]> git.karo-electronics.de Git - linux-beck.git/commit
bcm63xx_enet: avoid uninitialized variable warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 18 Jan 2017 14:52:53 +0000 (15:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Jan 2017 16:45:37 +0000 (11:45 -0500)
commitdf384d435a5c034c735df3d9ea87a03172c59b56
treef2b91f744f32f734373a30e01bab5cea8b6c5ca7
parent0629a330cf55454962168dd3ee46fad53a39323e
bcm63xx_enet: avoid uninitialized variable warning

gcc-7 and probably earlier versions get confused by this function
and print a harmless warning:

drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open':
drivers/net/ethernet/broadcom/bcm63xx_enet.c:1130:3: error: 'phydev' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This adds an initialization for the 'phydev' variable when it is unused
and changes the check to test for that NULL pointer to make it clear
that we always pass a valid pointer here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcm63xx_enet.c