]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Partially Revert "of: fix sparse warnings in fdt, irq, reserved mem, and resolver...
authorRob Herring <robh@kernel.org>
Thu, 11 May 2017 15:15:10 +0000 (10:15 -0500)
committerRob Herring <robh@kernel.org>
Thu, 11 May 2017 15:26:22 +0000 (10:26 -0500)
commitdf3ed932394488e57e72dd0e73c224d1804fdc8f
tree1dcc169c83da6c14e16fe51b936d3e18dee8650a
parent17a70355ea576843a7ac851f1db26872a50b2850
Partially Revert "of: fix sparse warnings in fdt, irq, reserved mem, and resolver code"

A change to function pointers that was meant to address a sparse warning
turned out to cause hundreds of new gcc-7 warnings:

include/linux/of_irq.h:11:13: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
drivers/of/of_reserved_mem.c: In function '__reserved_mem_init_node':
drivers/of/of_reserved_mem.c:200:7: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
   int const (*initfn)(struct reserved_mem *rmem) = i->data;

Turns out the sparse warnings were spurious and have been fixed in
upstream sparse since 0.5.0 in commit "sparse: treat function pointers
as pointers to const data".

This partially reverts commit 17a70355ea576843a7ac851f1db26872a50b2850.

Fixes: 17a70355ea57 ("of: fix sparse warnings in fdt, irq, reserved mem, and resolver code")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/of_reserved_mem.c
include/linux/of_irq.h