]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[PATCH] ipvs: fix connection leak if expire_nodest_conn=1
authorJulian Anastasov <ja@ssi.bg>
Wed, 9 Nov 2005 18:22:15 +0000 (10:22 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2005 05:18:55 +0000 (21:18 -0800)
commitdf9586ef73c1f8488e0a263ce9432e0d4118e0fc
tree427032425c1ddaed409c44804baf802ce69bed05
parent6b85cfab9d15c70392cd79896ae1a11d88498e9f
[PATCH] ipvs: fix connection leak if expire_nodest_conn=1

There was a fix in 2.6.13 that changed the behaviour of
ip_vs_conn_expire_now function not to put reference to connection, its
callers should hold write lock or connection refcnt. But we forgot to
convert one caller, when the real server for connection is unavailable
caller should put the connection reference. It happens only when sysctl
var expire_nodest_conn is set to 1 and such connections never expire.
Thanks to Roberto Nibali who found the problem and tested a 2.4.32-rc2
patch, which is equal to this 2.6 version.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Roberto Nibali <ratz@drugphish.ch>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/ipvs/ip_vs_core.c